VMware import - logs sanitation

[sureshanaparti]

Description

This PR sanitises logs of ovftool cmd during vmware import.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested, and checked the logs.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (1f8442e) to head (51af846).
Report is 15 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...s/src/main/java/com/cloud/utils/script/Script.java	0.00%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10433      +/-   ##
============================================
- Coverage     15.17%   15.16%   -0.01%     
+ Complexity    11340    11336       -4     
============================================
  Files          5414     5414              
  Lines        475093   475084       -9     
  Branches      57971    57970       -1     
============================================
- Hits          72086    72069      -17     
- Misses       394945   394956      +11     
+ Partials       8062     8059       -3     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.89% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kiranchavala]

@blueorangutan package

[blueorangutan]

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12522

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13258

[DaanHoogland]

clgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13308

[kiranchavala]

LGTM

Before fix

Cloudstack was logging the vcenter credentials

2025-05-15 12:34:05,970 DEBUG [resource.wrapper.LibvirtConvertInstanceCommandWrapper] (agentRequest-Handler-1:[]) (logid:edec8444) Executing command [ovftool --noSSLVerify vi://administrator%40vsphere.local:P%[email protected]/Trillian/vm/e552b5c2-f4d3-4c15-93a1-6a2c560df142 /mnt/a1047887-9e10-3157-9336-432b0b47ecfe/01a1d8ab-e41f-4fc6-a288-aac8b787a100/ ].

After fix

2025-05-15 11:54:53,033 DEBUG [resource.wrapper.LibvirtConvertInstanceCommandWrapper] (agentRequest-Handler-4:null) (logid:0fa4514f) Executing command [ovftool --noSSLVerify vi://******@10.0.35.100/Trillian/vm/5cbc76b0-feaf-40ab-ac0d-4abb09b72885 /mnt/f30da0ff-56c0-364d-9146-caa63d6d3de0/0c73a2e1-4113-423b-8359-958d41635464/ ]

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13323)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46545 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10433-t13323-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File