-
Notifications
You must be signed in to change notification settings - Fork 1.2k
systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 #10462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 #10462
Conversation
This bumps the version of the base OS ISO to Debian 12.9.0 and use ACS version identifier to be 4.20.1 (next release). Signed-off-by: Rohit Yadav <[email protected]>
|
I've kicked multi-arch builds which will be available here in 2-3 hrs (the arm64 builds on x86 machine are slow): https://build.yadav.cloud/systemvm/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10462 +/- ##
=========================================
Coverage 15.99% 15.99%
Complexity 13086 13086
=========================================
Files 5649 5649
Lines 495710 495710
Branches 60013 60013
=========================================
+ Hits 79286 79288 +2
+ Misses 407574 407572 -2
Partials 8850 8850
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, some practical questions
Should we use these builds to upload to downloads.cloudstack.org?
And will you honour us with testing the arm versions?
Pearl1594
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
|
I'll merge this based on the builds, for actual testing, these templates can be used. For now, the scope of the PR was to ensure builds work with the corrected ISO urls. Around mid-march I'm happy to do new sets of builds and move them to download.cloudstack.org server and update root & engine/schema pom.xml with the systemvmtemplate version. cc @Pearl1594 @DaanHoogland |
…0462) This bumps the version of the base OS ISO to Debian 12.9.0 and use ACS version identifier to be 4.20.1 (next release). Signed-off-by: Rohit Yadav <[email protected]>
This bumps the version of the base OS ISO to Debian 12.9.0 and use ACS version identifier to be 4.20.1 (next release).
Also fixes the build failures (iso links 404).
Types of changes