List only VMs associated to a userdata

[Pearl1594]

Description

This PR fixes issue brought up here: #10549 (comment)
Where currently it's not possible to list all VMs associated to a user data.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before fix:

Incorrect as the userdata is only associated with 1 VM. The userdata parameter of the listVMs API is to control whether or not to return the userdata as part of the listVms response

After fix:

How did you try to break this feature and the system with this change?

[Pearl1594]

@blueorangutan package

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (95c2481) to head (692a80b).
Report is 2 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	5 Missing ⚠️
...che/cloudstack/api/command/user/vm/ListVMsCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10569   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11326    11328    +2     
=========================================
  Files          5414     5414           
  Lines        474804   474867   +63     
  Branches      57909    57930   +21     
=========================================
+ Hits          72002    72019   +17     
- Misses       394749   394794   +45     
- Partials       8053     8054    +1     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.89% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12784

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12702)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10569-t12702-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

Code LGTM

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12811