UI: Change resource settings to be type based #10596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10596 +/- ##
============================================
+ Coverage 16.17% 16.29% +0.12%
- Complexity 13291 13437 +146
============================================
Files 5668 5674 +6
Lines 498179 499203 +1024
Branches 60290 60368 +78
============================================
+ Hits 80581 81368 +787
- Misses 408578 408765 +187
- Partials 9020 9070 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
bernardodemarco
approved these changes
Mar 27, 2025
Member
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, nice work @lucas-a-martins
Tested updating and resetting configuration values, and filtering settings by name
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Co-authored-by: Lucas Martins <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the only way to update a value in the resource settings tabs is by typing the new value as a text, regardless of its type (boolean, range, percentage, etc).
This PR change this behavior to work like the global settings, where the edition is based on the value type.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
I tested it by accessing each affected settings tab to confirm that the changes were applied.
I also changed some configurations values to see if everything still works as intended.