Skip to content

ui: fix considerlasthost for start vm #10602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Mar 24, 2025
Merged

ui: fix considerlasthost for start vm #10602

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe8e99
ui: fix considerlasthost for start vm
shwstppr Mar 21, 2025
6252610
fix for group action
shwstppr Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/compute/StartVirtualMachine.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export default {
id: this.resource.id
}
for (const key in values) {
if (values[key]) {
if (values[key] || values[key] === false) {
Copy link
Member

@bernardodemarco bernardodemarco Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we simply remove this if condition? I don't see how a form's field value could be null or undefined here

Copy link
Contributor Author

@shwstppr shwstppr Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernardodemarco It may be there because some fields may have an empty value which we shouldn't pass to the API

Copy link
Member

@bernardodemarco bernardodemarco Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Specifically in this form, in which all fields are select components (except for the considerlasthost), the UI does not allow the values to be empty.

However, I think that's a great idea to keep the if statement how you proposed, since that we could, in the future, add more fields to the form that can accept empty/nullable values

params[key] = values[key]
}
}
Expand Down