Skip to content

Always separate decimals by a dot in metrics response #10699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
winterhazel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Always separate decimals by a dot in metrics response #10699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@

import java.lang.reflect.InvocationTargetException;
import java.text.DecimalFormat;
import java.text.DecimalFormatSymbols;
import java.util.ArrayList;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Properties;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -461,8 +463,8 @@ protected ListResponse<VmMetricsStatsResponse> createVmMetricsStatsResponse(List
* @return the set of responses that was created.
*/
protected List<StatsResponse> createStatsResponse(List<VmStatsVO> vmStatsList) {
List<StatsResponse> statsResponseList = new ArrayList<StatsResponse>();
DecimalFormat decimalFormat = new DecimalFormat("#.##");
List<StatsResponse> statsResponseList = new ArrayList<>();
DecimalFormat decimalFormat = new DecimalFormat("#.##", DecimalFormatSymbols.getInstance(Locale.ENGLISH));
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the DecimalFormat instantiation into a private static final constant, since the pattern and locale are constant. This reduces object creation overhead on each method call.

Suggested change
DecimalFormat decimalFormat = new DecimalFormat("#.##", DecimalFormatSymbols.getInstance(Locale.ENGLISH));
DecimalFormat decimalFormat = DECIMAL_FORMAT.get();

Copilot uses AI. Check for mistakes.
for (VmStatsVO vmStats : vmStatsList) {
StatsResponse response = new StatsResponse();
response.setTimestamp(vmStats.getTimestamp());
Expand Down