Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR makes the LDAP configurations "ldap.truststore" and "ldap.truststore.password" to address #10335

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (d32065f) to head (3a146a7).
Report is 2 commits behind head on 4.19.

❗ There is a different number of reports uploaded between BASE (d32065f) and HEAD (3a146a7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d32065f) HEAD (3a146a7)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.19   #10711       +/-   ##
=============================================
- Coverage     15.16%    4.28%   -10.88%     
=============================================
  Files          5415      369     -5046     
  Lines        474849    29676   -445173     
  Branches      57914     5208    -52706     
=============================================
- Hits          72011     1272    -70739     
+ Misses       394788    28259   -366529     
+ Partials       8050      145     -7905     
Flag Coverage Δ
uitests 4.28% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 closed this Apr 14, 2025
@sonarqubecloud
Copy link

@DaanHoogland DaanHoogland deleted the change-ldaps-config-nonDynamic branch April 30, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant