-
Notifications
You must be signed in to change notification settings - Fork 1.2k
cloudutils: use "ip route" command instead of "route -n" in networkConfig.py #10726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudutils: use "ip route" command instead of "route -n" in networkConfig.py #10726
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10726 +/- ##
============================================
- Coverage 15.17% 15.17% -0.01%
Complexity 11332 11332
============================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
============================================
- Hits 72046 72042 -4
- Misses 394792 394796 +4
Partials 8055 8055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13062 |
|
@blueorangutan test |
|
@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13035)
|
Description
This PR uses 'ip route' command instead of 'route -n' command in networkConfig.py
routeis provided by legacynet-toolspackage which is not installed by default in some distributionsipis provided byiproute2package which is a dependency of cloudstack-agent packagethe two commands have the same result
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?