2fa: log error on totp mismatch

[shwstppr]

Description

Addresses #9515

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.65%. Comparing base (6850147) to head (150809c).
⚠️ Report is 254 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...loudstack/auth/TotpUserTwoFactorAuthenticator.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10734      +/-   ##
============================================
+ Coverage     16.01%   16.65%   +0.64%     
- Complexity    13112    13951     +839     
============================================
  Files          5652     5660       +8     
  Lines        495817   530243   +34426     
  Branches      60045    74479   +14434     
============================================
+ Hits          79404    88335    +8931     
- Misses       407551   432084   +24533     
- Partials       8862     9824     +962     

Flag	Coverage Δ
uitests	4.41% <ø> (+0.41%)	⬆️
unittests	17.45% <0.00%> (+0.59%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13073

[Pearl1594]

code lgtm.

[weizhouapache]

code lgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

this is simple change with debugging, smoke test is not needed
I will merge when packaging job is done

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14893

[harikrishna-patnala]

LGTM