ssvm: use mgmt network if no storage network

[shwstppr]

Description

Fixes #10163

Based on #10163 (comment)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (db5b6a5) to head (1b02b91).
⚠️ Report is 20 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../storage/resource/NfsSecondaryStorageResource.java	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10735   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13286    13299   +13     
=========================================
  Files          5656     5656           
  Lines        498015   498091   +76     
  Branches      60406    60416   +10     
=========================================
+ Hits          80538    80589   +51     
- Misses       408515   408536   +21     
- Partials       8962     8966    +4     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	17.03% <76.92%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13072

[weizhouapache]

@shwstppr
I would like to re-open and test this PR against 4.20
what do you think ?

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[shwstppr]

@weizhouapache I've re-opened and rebased it for 4.20

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

@weizhouapache I've re-opened and rebased it for 4.20
thanks @shwstppr , I will test it

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14210)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 66385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10735-t14210-kvm-ol8.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeleteDomain	Error	364.93	test_accounts.py
test_forceDeleteDomain	Failure	104.64	test_accounts.py
ContextSuite context=TestRemoteDiagnostics>:setup	Error	0.00	test_diagnostics.py
test_list_vms_metrics_admin	Error	3610.25	test_metrics_api.py
test_list_vms_metrics_history	Error	6.53	test_metrics_api.py
test_list_volumes_metrics_history	Error	4.46	test_metrics_api.py

[weizhouapache]

@shwstppr
the issue #10163 is present in my testing

it looks like we need to set the storage netmask and gateway too

diff --git a/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java b/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
index 454b98d0f6e..4eb45f2b5b9 100644
--- a/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
+++ b/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
@@ -2744,8 +2744,8 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
         if (_storageIp == null && _inSystemVM) {
             logger.warn("There is no storageip in /proc/cmdline, something wrong!");
         }
-        _storageNetmask = (String)params.get("storagenetmask");
-        _storageGateway = (String)params.get("storagegateway");
+        _storageNetmask = MapUtils.getString(params, "storagenetmask", _eth1mask);
+        _storageGateway = MapUtils.getString(params, "storagegateway", (String)params.get("localgw"));
         super.configure(name, params);
 
         _params = params;

[shwstppr]

@weizhouapache thanks for the tests. I've made some changes

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14905

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14907

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14248)

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14251)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62036 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10735-t14251-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	Failure	133.10	test_templates.py
test_06_download_detached_volume	Failure	436.77	test_volumes.py

[blueorangutan]

[SF] Trillian test result (tid-14255)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 63889 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10735-t14255-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

Verified OK

root@s-15-VM:~# grep 'Storage network not configured' /var/log/cloud.log 
2025-09-10T07:40:53,726 INFO  [storage.resource.NfsSecondaryStorageResource] (main:[]) Storage network not configured, using management network[ip: 10.0.42.34, netmask: 255.255.240.0, gateway: 10.0.32.1] for storage traffic

root@s-15-VM:~# grep 'ip route add' /var/log/cloud.log 
root@s-15-VM:~# 

[harikrishna-patnala]

code LGTM

[weizhouapache]

Merging based on approvals and manual test results