Extra checks in UI when deleting accounts

[Imvedansh]

Description

This PR fixes #9480

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Imvedansh]

@blueorangutan ui

[blueorangutan]

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-604)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (9d9737a) to head (1d3e374).
Report is 7 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10760   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11332    11337    +5     
=========================================
  Files          5412     5414    +2     
  Lines        475043   475078   +35     
  Branches      57963    57966    +3     
=========================================
+ Hits          72049    72069   +20     
- Misses       394939   394951   +12     
- Partials       8055     8058    +3     

Flag	Coverage Δ
uitests	4.29% <ø> (-0.01%)	⬇️
unittests	15.89% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Imvedansh]

@blueorangutan ui

[blueorangutan]

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build failed: ✖️
(SL-JID-605)

[Imvedansh]

@blueorangutan ui

[blueorangutan]

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-606)

[Imvedansh]

@bernardodemarco WDYT?

[DaanHoogland]

looks good, tested in qa

[DaanHoogland]

@Imvedansh , were you going to implement the multiple delete as well?

[Imvedansh]

@Imvedansh , were you going to implement the multiple delete as well?

yes, without it this would be fragmental!
Working on it @DaanHoogland

[bernardodemarco]

@Imvedansh looking nice. Here are some suggestions.

[Imvedansh]

@blueorangutan ui

[blueorangutan]

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10760 (QA-JID-609)

[DaanHoogland]

@bernardodemarco can you check again?

[bernardodemarco]

lgtm, verified in the QA env

[DaanHoogland]

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

[Imvedansh]

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

[DaanHoogland]

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

ok, add a new PR if you want to improve more ;)

[Imvedansh]

@Imvedansh , this is tested and reviewed, but still in draft. Do you consider it ready?

@DaanHoogland Yes, it's ready. I was just working on making it more efficient and easier to understand for future contributors, will live it asap

ok, add a new PR if you want to improve more ;)

Perfectoooo :)!