Skip to content

Conversation

@bernardodemarco
Copy link
Member

Description

Currently, the hosts listing displays the number of end-user VMs allocated on each host. This PR proposes to also display the number of system VMs allocated on the hosts.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

  • Before:

image

  • After:

image

How Has This Been Tested?

  • Accessed the hosts listing and verified that the number of system VMs allocated on the hosts was correctly displayed.

@bernardodemarco bernardodemarco added this to the 4.20.1 milestone Apr 29, 2025
@bernardodemarco
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.13%. Comparing base (0e0ae22) to head (4201e27).
Report is 2 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10791   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
- Complexity    13215    13216    +1     
=========================================
  Files          5649     5649           
  Lines        496692   496692           
  Branches      60175    60175           
=========================================
+ Hits          80135    80146   +11     
+ Misses       407633   407622   -11     
  Partials       8924     8924           
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10791 (QA-JID-608)

@DaanHoogland
Copy link
Contributor

great improvement @bernardodemarco , I have one question; by the look of the code this would apply to the normal list view and to the metrics list view, but in QA I only see the extra column in the metrics view:
Screenshot 2025-04-30 at 09 19 29
Screenshot 2025-04-30 at 09 19 48

Is this

  • expected vs my expectation,
  • something wrong in the qa env or
  • should this change be applied in a second location?

tnx

@bernardodemarco
Copy link
Member Author

@DaanHoogland, yes, it should be displayed by default both on the normal list view and on the metrics view. Maybe, could this be related to browser caching?

I accessed the QA environment in a private tab, and this is the default host list view that appears for me:

2025-04-30.08-14-45.mp4

The same behavior also occurs in my local environment.

@DaanHoogland
Copy link
Contributor

thanks @bernardodemarco , I am using duckduckgo browser and thought it would not cache anything. I was so wrong 🤦 .

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud rohityadavcloud merged commit 02d1c61 into apache:4.20 May 1, 2025
18 of 25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants