Skip to content

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented May 2, 2025

Description

This PR fixes the CI failure noticed on the test_outofbandmanagement.py test run: https://github.com/apache/cloudstack/actions/runs/14738890400/job/41371735260?pr=10668
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/smoke/test_outofbandmanagement.py 

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /tmp/MarvinLogs/May_02_2025_14_49_52_WEW86D All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_oobm_background_powerstate_sync | Status : SUCCESS ===

=== TestName: test_oobm_configure_default_driver | Status : SUCCESS ===

=== TestName: test_oobm_configure_invalid_driver | Status : SUCCESS ===

=== TestName: test_oobm_disable_feature_invalid | Status : SUCCESS ===

=== TestName: test_oobm_disable_feature_valid | Status : SUCCESS ===

=== TestName: test_oobm_enable_feature_invalid | Status : SUCCESS ===

=== TestName: test_oobm_enable_feature_valid | Status : SUCCESS ===

=== TestName: test_oobm_enabledisable_across_clusterzones | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_cycle | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_off | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_on | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_reset | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_soft | Status : SUCCESS ===

=== TestName: test_oobm_issue_power_status | Status : SUCCESS ===

=== TestName: test_oobm_multiple_mgmt_server_ownership | Status : FAILED ===     <---- needs to be looked into caused due to mshost_peer constraints not being met

=== TestName: test_oobm_zchange_password | Status : SUCCESS ===

=== Final results are now copied to: /tmp/MarvinLogs/test_outofbandmanagement_PQX3OF ===

CI passing: (with the exception of 1 - will be handled separately)
https://github.com/apache/cloudstack/actions/runs/14792734838/job/41533186875?pr=10805

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 changed the base branch from main to 4.20 May 2, 2025 09:36
@Pearl1594 Pearl1594 added this to the 4.20.1 milestone May 2, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 May 2, 2025
@Pearl1594 Pearl1594 changed the title Fix ci test oomb Update dependency required for test_outofbandmanagement.py May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.63%. Comparing base (32cc45e) to head (78da16c).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@              Coverage Diff              @@
##               4.19   #10805       +/-   ##
=============================================
+ Coverage     15.17%   17.63%    +2.45%     
- Complexity    11335    15870     +4535     
=============================================
  Files          5412     5657      +245     
  Lines        475056   621629   +146573     
  Branches      57967    99615    +41648     
=============================================
+ Hits          72069   109597    +37528     
- Misses       394929   501290   +106361     
- Partials       8058    10742     +2684     
Flag Coverage Δ
uitests 4.62% <ø> (+0.32%) ⬆️
unittests 18.44% <ø> (+2.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 May 2, 2025
@DaanHoogland DaanHoogland reopened this May 2, 2025
@DaanHoogland
Copy link
Contributor

@Pearl1594 , this one also fails on the GH-actions for 4.19. Can you rebase?

@Pearl1594 Pearl1594 force-pushed the fix-ci-test-oomb branch from 006d184 to 78da16c Compare May 2, 2025 12:53
@Pearl1594 Pearl1594 changed the base branch from 4.20 to 4.19 May 2, 2025 12:53
@apache apache deleted a comment from blueorangutan May 2, 2025
@apache apache deleted a comment from blueorangutan May 2, 2025
@DaanHoogland DaanHoogland reopened this May 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2025

@DaanHoogland DaanHoogland merged commit d697cff into 4.19 May 2, 2025
63 of 75 checks passed
@DaanHoogland DaanHoogland deleted the fix-ci-test-oomb branch May 2, 2025 15:34
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants