-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Completed config option to allow nested virtualization #10812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4846,6 +4846,8 @@ protected long getMemoryFreeInKBs(Domain dm) throws LibvirtException { | |||||||||||
| } | ||||||||||||
|
|
||||||||||||
| private boolean canBridgeFirewall(final String prvNic) { | ||||||||||||
| if (getAllowNestedVMAccess()) | ||||||||||||
| return true; // If nested VM is allowed, then we skip call to security group and allow bypassing firewall | ||||||||||||
|
Comment on lines
+4849
to
+4850
|
||||||||||||
| if (getAllowNestedVMAccess()) | |
| return true; // If nested VM is allowed, then we skip call to security group and allow bypassing firewall | |
| if (getAllowNestedVMAccess()) { | |
| return true; // If nested VM is allowed, then we skip call to security group and allow bypassing firewall | |
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -329,6 +329,9 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage | |
|
|
||
| public static final ConfigKey<Integer> PUBLIC_IP_ADDRESS_QUARANTINE_DURATION = new ConfigKey<>("Network", Integer.class, "public.ip.address.quarantine.duration", | ||
| "0", "The duration (in minutes) for the public IP address to be quarantined when it is disassociated.", true, ConfigKey.Scope.Domain); | ||
|
|
||
| public static final ConfigKey<Boolean> AllowNestedVMAccess = new ConfigKey<>("Advanced", Boolean.class, "allow.nested.vm.access", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bradywilkin |
||
| "false", "Allows nested VM access by bypassing security group restrictions. Use with caution.", true, ConfigKey.Scope.Global); | ||
|
|
||
| private Random rand = new Random(System.currentTimeMillis()); | ||
|
|
||
|
|
@@ -2453,6 +2456,10 @@ public static ConfigKey<Boolean> getSystemvmpublicipreservationmodestrictness() | |
| return SystemVmPublicIpReservationModeStrictness; | ||
| } | ||
|
|
||
| public static ConfigKey<Boolean> getAllowNestedVMAccess() { | ||
| return AllowNestedVMAccess; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean canPublicIpAddressBeAllocated(IpAddress ip, Account newOwner) { | ||
| PublicIpQuarantineVO publicIpQuarantineVO = publicIpQuarantineDao.findByPublicIpAddressId(ip.getId()); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the method in LibvirtComputingResource are executed on the kvm host (part of cloudstack-agent)
The host cannot access the database.
so, this won't work.
a feasible way is, adding a setting to agent.properties