Skip to content

Conversation

@abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented May 14, 2025

Description

This PR fixes a bug where Assign / Remove Backup offering buttons are shown incorrectly in the details view in UI.

List View:
Screenshot from 2025-05-14 19-15-48

Details View:
Screenshot from 2025-05-14 19-16-09

This is because the listVirtualMachinesMetrics api sent during detals view doesn't send the backoff string in details and does not get backup offering information for the VM.

This is an offshoot of, although not caused directly by #9825
Before the above PR, listVirtualMachines api was sent by UI in details view also which had the backoff string in details.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@abh1sar
Copy link
Collaborator Author

abh1sar commented May 14, 2025

@blueorangutan ui

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.14%. Comparing base (b8359e8) to head (78f6d2d).
Report is 121 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10867      +/-   ##
============================================
+ Coverage     16.00%   16.14%   +0.13%     
- Complexity    13104    13237     +133     
============================================
  Files          5651     5655       +4     
  Lines        495841   497311    +1470     
  Branches      60044    60277     +233     
============================================
+ Hits          79365    80278     +913     
- Misses       407613   408089     +476     
- Partials       8863     8944      +81     
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) ⬆️
unittests 16.99% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone May 14, 2025
@rohityadavcloud rohityadavcloud requested a review from Pearl1594 May 14, 2025 14:23
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10867 (QA-JID-624)

@Pearl1594 Pearl1594 merged commit 3df83da into apache:4.20 May 14, 2025
20 of 25 checks passed
@Pearl1594 Pearl1594 deleted the back-off branch May 14, 2025 15:12
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 26, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants