linstor: fix host connect recursion regression

[rp-]

Description

PR #9873 changed the default implementation of hostConnect on the DefaultHostListener, and Linstor tried to call the none existent default implementation. With the change in the PR a recursion was triggered that triggered a StackOverflow and stopped adding Linstor primary storage.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Creating a new cluster with Linstor primary storage

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 16.14%. Comparing base (3df83da) to head (6727e48).
Report is 1 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...torage/datastore/provider/LinstorHostListener.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10878      +/-   ##
============================================
- Coverage     16.14%   16.14%   -0.01%     
+ Complexity    13238    13237       -1     
============================================
  Files          5655     5655              
  Lines        497311   497310       -1     
  Branches      60277    60277              
============================================
- Hits          80291    80278      -13     
- Misses       408076   408089      +13     
+ Partials       8944     8943       -1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.99% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[slavkap]

I cannot test it, but the code LGTM

[DaanHoogland]

Linstor code; trusting author testing.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13410

[rohityadavcloud]

LGTM - code changes are strictly in Linstor plugin, we can merge based on @rp- 's own testing.