Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jun 3, 2025

Description

Some changes from #10115 seems to be missing on main branch

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Some changes from apache#10115 seems to be missing on main branch

Signed-off-by: Abhishek Kumar <[email protected]>
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (7632814) to head (cc098e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10949      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
  Complexity    13868    13868              
============================================
  Files          5719     5719              
  Lines        507178   507184       +6     
  Branches      61571    61572       +1     
============================================
- Hits          84085    84082       -3     
- Misses       413674   413686      +12     
+ Partials       9419     9416       -3     
Flag Coverage Δ
uitests 3.96% <ø> (-0.01%) ⬇️
unittests 17.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @shwstppr!

I've gone through all changes of the original PR (#10115) and verified that the SearchView changes are missing in the main branch.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (most likely my bad :( )

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10949 (QA-JID-636)

@shwstppr shwstppr marked this pull request as ready for review June 4, 2025 05:26
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr, I've also verified in the QA env:

image

The filtering is not performed because the QA environment's backend is in the 4.20.0.0 version, and the API changes introduced on #10115 were targeted to the 4.21 version.

@DaanHoogland DaanHoogland merged commit 41b4f0a into apache:main Jun 4, 2025
22 of 25 checks passed
@DaanHoogland DaanHoogland deleted the ui-missing-pr10115 branch June 4, 2025 18:13
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants