-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add check for ldap truststore password #11055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11055 +/- ##
============================================
- Coverage 15.18% 15.17% -0.01%
+ Complexity 11365 11362 -3
============================================
Files 5416 5416
Lines 475890 475911 +21
Branches 58093 58096 +3
============================================
- Hits 72254 72241 -13
- Misses 395550 395584 +34
Partials 8086 8086
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ns/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapContextFactory.java
Outdated
Show resolved
Hide resolved
...ns/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapContextFactory.java
Show resolved
Hide resolved
|
rajujith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested, fixes the issue I reported.
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@weizhouapache any concerns left? |
I did , but chatgpt answered me, so no concerns now. |
* 4.19: Add check for ldap truststore password (#11055)





Description
This PR adds validation for the ldap truststore password before adding the ldap server.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?