[Multi-Arch] Select Template Arch when creating template from volume #11068

nvazquez · 2025-06-21T17:28:42Z

Description

This PR allows selecting the template arch when creating a template from volume

(the created template was always x86_64 and could be edited after its creation)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested on Multi-Arch zone with 2 clusters each one with arch: x86_64 and aarch64
Create template from volume of an aarch 64 VM -> select aarch64 arch -> verify the created template arch

How did you try to break this feature and the system with this change?

codecov · 2025-06-21T17:36:12Z

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.16%. Comparing base (1b74c2d) to head (017296a).
⚠️ Report is 18 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...k/api/command/user/template/CreateTemplateCmd.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11068      +/-   ##
============================================
- Coverage     16.16%   16.16%   -0.01%     
  Complexity    13278    13278              
============================================
  Files          5656     5656              
  Lines        497813   497884      +71     
  Branches      60373    60378       +5     
============================================
+ Hits          80458    80461       +3     
- Misses       408401   408468      +67     
- Partials       8954     8955       +1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.01% <25.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nvazquez · 2025-06-21T20:30:03Z

@blueorangutan package

blueorangutan · 2025-06-21T20:32:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-21T21:38:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13865

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java

…ate/CreateTemplateCmd.java Co-authored-by: Abhishek Kumar <[email protected]>

nvazquez · 2025-06-22T17:41:47Z

@blueorangutan package

blueorangutan · 2025-06-22T17:44:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-22T18:49:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13870

DaanHoogland

clgtm

shwstppr

Code LGTM

shwstppr · 2025-06-30T11:38:25Z

@blueorangutan test

blueorangutan · 2025-06-30T11:40:04Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-01T05:55:29Z

[SF] Trillian test result (tid-13639)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 62788 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11068-t13639-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestISO>:setup	`Error`	1565.91	test_iso.py

sureshanaparti · 2025-07-23T18:04:52Z

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java


+    @Parameter(name = ApiConstants.ARCH, type = CommandType.STRING,
+            description = "the CPU arch of the template. Valid options are: x86_64, aarch64",
+            since = "4.20.2")


Suggested change

since = "4.20.2")

since = "4.21.0")

if this is part of 4.21

it is based off of 4.20 @sureshanaparti , I think it is good like this.

@DaanHoogland is it ok if it goes in 4.21 first (before 4.20.2)?

if both versions are to use the same template (which it looks like ti is going to be).

sureshanaparti

clgtm

sureshanaparti · 2025-07-23T18:05:51Z

@blueorangutan package

blueorangutan · 2025-07-23T18:08:06Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-23T20:26:56Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14322

sureshanaparti · 2025-07-24T04:03:50Z

@blueorangutan package

blueorangutan · 2025-07-24T04:06:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-24T06:35:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14333

vishesh92 · 2025-07-26T07:47:23Z

@blueorangutan ui

blueorangutan · 2025-07-26T07:48:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java

Copilot

Pull Request Overview

This PR enhances the template creation feature to allow users to select the CPU architecture when creating a template from a volume, addressing the limitation where templates were always created with x86_64 architecture regardless of the source volume's architecture.

Adds architecture selection dropdown to the UI template creation form
Modifies the backend API to accept and process the architecture parameter
Updates the template creation logic to use the specified architecture instead of defaulting to x86_64

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
ui/src/views/storage/CreateTemplate.vue	Adds architecture selection dropdown with CPU architecture types fetched from the store
api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java	Adds arch parameter to the CreateTemplateCmd API with validation
server/src/main/java/com/cloud/template/TemplateManagerImpl.java	Updates template creation logic to use the provided architecture instead of hardcoded x86_64

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

blueorangutan · 2025-07-26T08:05:15Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11068 (QA-JID-690)

vishesh92

Just one minor comment. Otherwise code looks good to me.

…ate/CreateTemplateCmd.java Co-authored-by: Vishesh <[email protected]>

nvazquez · 2025-07-28T10:38:34Z

Thanks @vishesh92 - comment addressed

@blueorangutan package

blueorangutan · 2025-07-28T10:40:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-28T11:55:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14419

nvazquez · 2025-07-28T12:41:52Z

@blueorangutan test

blueorangutan · 2025-07-28T12:44:04Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-29T05:53:05Z

[SF] Trillian test result (tid-13941)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11068-t13941-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	`Failure`	5.22	test_diagnostics.py
test_09_arping_in_cpvm	`Failure`	5.22	test_diagnostics.py

…pache#11068) Co-authored-by: Abhishek Kumar <[email protected]> Co-authored-by: Suresh Kumar Anaparti <[email protected]> Co-authored-by: Vishesh <[email protected]>

[Multi-Arch] Select Template Arch when creating template from volume

07be7dd

nvazquez added this to the 4.20.2 milestone Jun 21, 2025

nvazquez requested review from DaanHoogland, Pearl1594, rohityadavcloud, shwstppr and sureshanaparti June 21, 2025 17:28

boring-cyborg bot added component:api component:UI labels Jun 21, 2025

shwstppr reviewed Jun 22, 2025

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java Outdated Show resolved Hide resolved

Update api/src/main/java/org/apache/cloudstack/api/command/user/templ…

340e953

…ate/CreateTemplateCmd.java Co-authored-by: Abhishek Kumar <[email protected]>

DaanHoogland approved these changes Jun 23, 2025

View reviewed changes

shwstppr approved these changes Jun 30, 2025

View reviewed changes

sureshanaparti reviewed Jul 23, 2025

View reviewed changes

sureshanaparti approved these changes Jul 23, 2025

View reviewed changes

Merge branch '4.20' into 420-multiarch-createtmpl-fromvol

41144c8

vishesh92 reviewed Jul 26, 2025

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java Outdated Show resolved Hide resolved

vishesh92 requested a review from Copilot July 26, 2025 07:59

Copilot AI reviewed Jul 26, 2025

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java Show resolved Hide resolved

server/src/main/java/com/cloud/template/TemplateManagerImpl.java Show resolved Hide resolved

vishesh92 approved these changes Jul 26, 2025

View reviewed changes

Update api/src/main/java/org/apache/cloudstack/api/command/user/templ…

017296a

…ate/CreateTemplateCmd.java Co-authored-by: Vishesh <[email protected]>

DaanHoogland merged commit 8756be5 into apache:4.20 Jul 29, 2025
26 checks passed

DaanHoogland deleted the 420-multiarch-createtmpl-fromvol branch July 29, 2025 09:41

[Multi-Arch] Select Template Arch when creating template from volume #11068

[Multi-Arch] Select Template Arch when creating template from volume #11068

Uh oh!

Conversation

nvazquez commented Jun 21, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nvazquez commented Jun 21, 2025

Uh oh!

blueorangutan commented Jun 21, 2025

Uh oh!

blueorangutan commented Jun 21, 2025

Uh oh!

Uh oh!

nvazquez commented Jun 22, 2025

Uh oh!

blueorangutan commented Jun 22, 2025

Uh oh!

blueorangutan commented Jun 22, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jun 30, 2025

Uh oh!

blueorangutan commented Jun 30, 2025

Uh oh!

blueorangutan commented Jul 1, 2025

Uh oh!

sureshanaparti Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

sureshanaparti commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

vishesh92 commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codecov bot commented Jun 21, 2025 •

edited

Loading