Skip to content

Conversation

@abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Jun 26, 2025

Description

This PR fixes #11092

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before fix:
minio-1
minio-2

After fix:
minio-after2
minio-after

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (4662ffc) to head (27b792f).
Report is 59 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11093      +/-   ##
============================================
- Coverage     16.60%   16.57%   -0.03%     
- Complexity    13927    13968      +41     
============================================
  Files          5730     5743      +13     
  Lines        508254   510496    +2242     
  Branches      61789    62076     +287     
============================================
+ Hits          84395    84615     +220     
- Misses       414420   416418    +1998     
- Partials       9439     9463      +24     
Flag Coverage Δ
uitests 3.90% <ø> (-0.04%) ⬇️
unittests 17.47% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jun 26, 2025

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13928

Copy link
Contributor

@fmaximus fmaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified using CloudStack Object Storage Browser UI on a MinIO backend.
Uploaded multiple file types (.txt, .jpg, .png, .pdf, .json, .xml, .csv) and confirmed they display correctly.
Content-Type handling is correct based on behavior in the UI.
Good enhancement!

Screenshot from 2025-07-23 12-58-33 Screenshot from 2025-07-23 12-57-04 Screenshot from 2025-07-23 12-48-59 Screenshot from 2025-07-23 12-48-02 Screenshot from 2025-07-23 12-47-07 image Screenshot from 2025-07-23 13-05-41

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11093 (QA-JID-679)

@sureshanaparti sureshanaparti merged commit d63899f into apache:main Jul 23, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 23, 2025
@sureshanaparti sureshanaparti deleted the minio-file-type branch July 23, 2025 10:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Object store browser not setting Content-Type correctly for files

6 participants