Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

Before Fix:
image

image

After Fix:
image
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (16c60c7) to head (d52ab65).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11101   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
  Complexity    13968    13968           
=========================================
  Files          5743     5743           
  Lines        510494   510494           
  Branches      62075    62075           
=========================================
  Hits          84617    84617           
  Misses       416415   416415           
  Partials       9462     9462           
Flag Coverage Δ
uitests 3.90% <ø> (ø)
unittests 17.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11101 (QA-JID-655)

@sonarqubecloud
Copy link

@DaanHoogland
Copy link
Contributor

@Pearl1594 , am I missing something or are the edit traffic label images for before and after the same?

@Pearl1594
Copy link
Contributor Author

the edit label images have no change, it indicates there was a label set.

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Traffic label for vmware are displayed properly

Screenshot 2025-07-17 at 8 14 35 AM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 15c09af into main Jul 17, 2025
48 of 49 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 17, 2025
@DaanHoogland DaanHoogland deleted the fix-trafficLabel-vmware branch July 17, 2025 07:31
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants