Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes: #11108

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

KVM Zone creation: (no longer shows the NSX public traffic creation)
Screenshot from 2025-07-03 16-02-55

KVM Zone - Disabled NSX network service provider:
Screenshot from 2025-07-03 16-59-39

VMware - Tested for regression:
listNetworkServiceProvider - initially shows state of nsp to be disabled
Screenshot from 2025-07-03 17-46-48

VMware - update operation is performed to enabled to NSP:
Screenshot from 2025-07-03 17-47-13

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.15%. Comparing base (ed7bd5e) to head (2aed8d6).
⚠️ Report is 49 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11142      +/-   ##
============================================
- Coverage     16.16%   16.15%   -0.01%     
  Complexity    13278    13278              
============================================
  Files          5657     5657              
  Lines        497969   497977       +8     
  Branches      60389    60391       +2     
============================================
- Hits          80472    80465       -7     
- Misses       408531   408549      +18     
+ Partials       8966     8963       -3     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 requested a review from kiranchavala July 14, 2025 18:15
@Pearl1594 Pearl1594 marked this pull request as ready for review July 23, 2025 18:04
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.20.2 milestone Jul 30, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14470

@DaanHoogland DaanHoogland merged commit 1dc134a into 4.20 Jul 30, 2025
46 of 47 checks passed
@DaanHoogland DaanHoogland deleted the ui-fix-display-nsx-provider branch July 30, 2025 12:11
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants