-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Display NSX Provider only when NSX is the selected Isolation method #11142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11142 +/- ##
============================================
- Coverage 16.16% 16.15% -0.01%
Complexity 13278 13278
============================================
Files 5657 5657
Lines 497969 497977 +8
Branches 60389 60391 +2
============================================
- Hits 80472 80465 -7
- Misses 408531 408549 +18
+ Partials 8966 8963 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kiranchavala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14470 |
Description
This PR fixes: #11108
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
KVM Zone creation: (no longer shows the NSX public traffic creation)

KVM Zone - Disabled NSX network service provider:

VMware - Tested for regression:

listNetworkServiceProvider - initially shows state of nsp to be disabled
VMware - update operation is performed to enabled to NSP:

How Has This Been Tested?
How did you try to break this feature and the system with this change?