Skip to content

Improve volume backup restoration log #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sureshanaparti merged 4 commits into from
Aug 3, 2025
Merged

Improve volume backup restoration log #11181

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
194b44c
improve logging
JoaoJandre Jul 11, 2025
2bb23e3
address reviews
JoaoJandre Jul 14, 2025
3a6b059
Merge remote-tracking branch 'origin/main' into improve-restore-log
JoaoJandre Jul 31, 2025
7514d72
fix rename
JoaoJandre Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@
import com.cloud.vm.dao.UserVmDao;
import com.cloud.vm.dao.VMInstanceDao;
import com.google.gson.Gson;
import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
import org.apache.commons.lang3.builder.ToStringStyle;

public class BackupManagerImpl extends ManagerBase implements BackupManager {

Expand Down Expand Up @@ -1071,7 +1073,7 @@
}
volumeInfo.setType(Volume.Type.DATADISK);

logger.debug("Attaching the restored volume to VM {}", vm);
logger.debug("Attaching the restored volume {} to VM {}.", () -> ReflectionToStringBuilder.toString(volumeInfo, ToStringStyle.JSON_STYLE), () -> vm);

Check warning on line 1076 in server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java#L1076 

Added line #L1076 was not covered by tests
StoragePoolVO pool = primaryDataStoreDao.findByUuid(datastoreUuid);
try {
return guru.attachRestoredVolumeToVirtualMachine(zoneId, restoredVolumeLocation, volumeInfo, vm, pool.getId(), backup);
Expand Down
Loading