Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Continuation of #10736

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <[email protected]>
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jul 25, 2025
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.74%. Comparing base (935c568) to head (5031824).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java 0.00% 1 Missing ⚠️
.../cloud/utils/crypt/EncryptionSecretKeyChanger.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11292   +/-   ##
=========================================
  Coverage     16.74%   16.74%           
  Complexity    14063    14063           
=========================================
  Files          5724     5724           
  Lines        507800   507800           
  Branches      61736    61736           
=========================================
  Hits          85039    85039           
  Misses       413278   413278           
  Partials       9483     9483           
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.66% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14363

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have not tested

@shwstppr shwstppr marked this pull request as ready for review July 25, 2025 12:29
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jul 25, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-13897)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60137 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11292-t13897-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sureshanaparti sureshanaparti merged commit 407072f into apache:main Jul 26, 2025
54 of 60 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 26, 2025
@vishesh92 vishesh92 deleted the fix-uvd-vid-change branch July 26, 2025 07:27
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
* schema,framework/db,server: fix user_vm_details usage

Continuation of apache#10736

* python files

Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants