Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

Description

This PR fixes local storage enable/disable toggle in Edit Zone dialog.

Fixes #11305

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified the local storage enable/disable from Edit Zone dialog in UI.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.99%. Comparing base (217ff27) to head (1c3a22c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11309      +/-   ##
============================================
+ Coverage     16.76%   16.99%   +0.23%     
- Complexity    14281    14717     +436     
============================================
  Files          5767     5832      +65     
  Lines        512657   517561    +4904     
  Branches      62359    62982     +623     
============================================
+ Hits          85941    87977    +2036     
- Misses       417118   419650    +2532     
- Partials       9598     9934     +336     
Flag Coverage Δ
uitests 3.82% <ø> (-0.04%) ⬇️
unittests 17.95% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11309 (QA-JID-695)

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified on my environment, LGTM

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested on simulator ui. works as expected.

@sureshanaparti sureshanaparti merged commit 45edf82 into apache:main Jul 28, 2025
23 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 28, 2025
@DaanHoogland DaanHoogland deleted the ui-localstorageenabled-toggle-fix branch July 28, 2025 13:00
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[UI] Local storage enable/disable toggle not working in Edit Zone dialog

4 participants