-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: make events tab selected columns persistent using cache #11317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: make events tab selected columns persistent using cache #11317
Conversation
Fixes apache#10308 Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11317 +/- ##
=========================================
Coverage 16.99% 16.99%
- Complexity 14715 14719 +4
=========================================
Files 5832 5832
Lines 517561 517569 +8
Branches 62982 62984 +2
=========================================
+ Hits 87975 87986 +11
+ Misses 419651 419649 -2
+ Partials 9935 9934 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, tested in QA; login set event details on the events tab, logout, login again, same details visible.
rajujith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Verified the improvement using the UI on the simulator. Works fine.
…1317) Fixes apache#10308 Signed-off-by: Abhishek Kumar <[email protected]>
Description
Fixes #10308
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?