Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Fixes #10306

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.17%. Comparing base (cca8b2f) to head (601b07d).
⚠️ Report is 401 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11319      +/-   ##
============================================
+ Coverage     16.99%   18.17%   +1.17%     
- Complexity    14715    16188    +1473     
============================================
  Files          5832     5886      +54     
  Lines        517561   559082   +41521     
  Branches      62982    77610   +14628     
============================================
+ Hits          87975   101616   +13641     
- Misses       419651   446419   +26768     
- Partials       9935    11047    +1112     
Flag Coverage Δ
uitests 4.42% <ø> (+0.59%) ⬆️
unittests 19.22% <ø> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr force-pushed the ui-allow-rootadminuseractions branch 2 times, most recently from 09f8191 to 0a44fec Compare July 29, 2025 05:34
@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr force-pushed the ui-allow-rootadminuseractions branch from 0a44fec to 601b07d Compare July 29, 2025 05:44
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11319 (QA-JID-697)

@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11319 (QA-JID-698)

@shwstppr shwstppr marked this pull request as ready for review August 5, 2025 10:56
@shwstppr shwstppr closed this Aug 5, 2025
@shwstppr shwstppr reopened this Aug 5, 2025
@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Sep 3, 2025
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tested with multiple admin accounts and with different admin role types.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but except for record.id !== store.userInfo.id the code is identical in three places. Maybe create a validation method?

EDIT: another difference spotted in the first compared to the other two places, but the remark holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Action button to enable 'ROOT admin' users

5 participants