server: trim autoscale Windows VM hostname #11327

shwstppr · 2025-07-29T10:16:01Z

Description

Fixes #9505

Trim the generated hostname for Windows VM to 15 characters.
Doc PR: apache/cloudstack-documentation#575

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-07-29T10:23:54Z

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (ac8c200) to head (d2544d4).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...ava/com/cloud/network/as/AutoScaleManagerImpl.java	90.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11327   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15544    15543    -1     
=========================================
  Files          5909     5909           
  Lines        529059   529074   +15     
  Branches      64617    64620    +3     
=========================================
+ Hits          92941    92944    +3     
- Misses       425664   425675   +11     
- Partials      10454    10455    +1

Flag	Coverage Δ
uitests	`3.58% <ø> (ø)`
unittests	`18.63% <90.47%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-07-30T06:22:40Z

@blueorangutan package

blueorangutan · 2025-07-30T06:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T08:56:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14463

github-actions · 2025-07-31T11:58:30Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2025-08-25T10:47:55Z

@shwstppr
is this ready for review ?

shwstppr · 2025-08-25T11:02:10Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

weizhouapache · 2025-08-25T11:18:31Z

@weizhouapache yes, though I wanted to confirm if it is a good idea to use the last 15 characters of the long generated name. Not using the first 15 as they can turn out to be the same.

@shwstppr
looks ok to me. I could not find a better solution to be honest.

is it possible the first letter is unaccepted (for example -) after the truncation ?

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

shwstppr · 2025-08-26T04:52:44Z

@blueorangutan package

blueorangutan · 2025-08-26T04:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-26T06:53:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14730

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

shwstppr · 2025-09-10T04:10:55Z

@blueorangutan package

blueorangutan · 2025-09-10T04:12:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-10T05:54:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14929

weizhouapache

code lgtm

DaanHoogland · 2025-09-15T08:12:51Z

@blueorangutan test

DaanHoogland

clgtm

abh1sar · 2025-09-30T10:44:40Z

@shwstppr I am getting this NPE with a Windows10 qcow2 template. Not sure if I did something wrong.
I have a mixed kvm, vmware env.

shwstppr · 2025-09-30T13:26:32Z

@blueorangutan package

blueorangutan · 2025-10-01T08:56:07Z

[SF] Trillian test result (tid-14488)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59706 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11327-t14488-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vishesh92

left some comments.

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

shwstppr · 2025-10-08T09:52:07Z

@blueorangutan package

blueorangutan · 2025-10-08T09:54:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-08T11:47:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15341

weizhouapache · 2025-10-08T12:18:48Z

Tested on Windows and Linux VM. The Windows VM name is getting truncated correctly.

to be frank, I think the name is a bit confusing

can we use a formatted shortname like asgroup-xxxxxx or asg-xx-xxxxxx instead ?

DaanHoogland · 2025-10-08T12:50:04Z

@weizhouapache @shwstppr is this not ready yet?

shwstppr · 2025-10-08T14:19:26Z

@DaanHoogland based on the latest comments I think we would need changes in naming implementation. I would close this for now for a different solution

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

Signed-off-by: Abhishek Kumar <[email protected]>

weizhouapache · 2025-11-07T09:19:55Z

discussed with @shwstppr , I made some changes on this PR on the name convention of autoscale Windows VM

now the vm name and display name look like

the last 6 letters are the same in the two names. they are generated by RandomStringUtils.random

weizhouapache · 2025-11-07T09:20:07Z

@blueorangutan package

blueorangutan · 2025-11-07T09:22:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-07T11:08:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15675

boring-cyborg bot added the component:networking label Jul 29, 2025

github-actions bot added the status:has-conflicts label Jul 31, 2025

github-actions bot removed the status:has-conflicts label Aug 1, 2025

shwstppr marked this pull request as ready for review August 25, 2025 11:02

DaanHoogland reviewed Aug 25, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

weizhouapache reviewed Aug 26, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

harikrishna-patnala added this to the 4.22.0 milestone Sep 3, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 3, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 3, 2025

weizhouapache approved these changes Sep 10, 2025

View reviewed changes

DaanHoogland approved these changes Sep 15, 2025

View reviewed changes

apache deleted a comment from blueorangutan Sep 30, 2025

vishesh92 reviewed Oct 1, 2025

View reviewed changes

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Show resolved Hide resolved

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java Outdated Show resolved Hide resolved

vishesh92 approved these changes Oct 8, 2025

View reviewed changes

shwstppr closed this Oct 8, 2025

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 8, 2025

shwstppr removed this from the 4.22.0 milestone Nov 4, 2025

shwstppr and others added 11 commits November 6, 2025 20:49

server: trim autoscale Windows VM hostname

a4147ef

Fixes apache#9505 Signed-off-by: Abhishek Kumar <[email protected]>

fix

e23d5ca

Signed-off-by: Abhishek Kumar <[email protected]>

fix imports

5eff910

Signed-off-by: Abhishek Kumar <[email protected]>

improve

bbb7f3e

Signed-off-by: Abhishek Kumar <[email protected]>

return if okay

001f320

Signed-off-by: Abhishek Kumar <[email protected]>

address comment

9fe7062

Signed-off-by: Abhishek Kumar <[email protected]>

fix

64a7a1c

Signed-off-by: Abhishek Kumar <[email protected]>

missing test change

af7fd5d

Signed-off-by: Abhishek Kumar <[email protected]>

avoid chances of npe if both guestos name and displayname are null

0e9fd67

Signed-off-by: Abhishek Kumar <[email protected]>

change

6d28bd2

Signed-off-by: Abhishek Kumar <[email protected]>

as: simplify windows vm name

d2544d4

weizhouapache reopened this Nov 7, 2025

weizhouapache force-pushed the fix-autoscalewinvm branch from d24ffc3 to d2544d4 Compare November 7, 2025 09:17

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

server: trim autoscale Windows VM hostname #11327

Are you sure you want to change the base?

server: trim autoscale Windows VM hostname #11327

Uh oh!

Conversation

shwstppr commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

shwstppr commented Aug 25, 2025

Uh oh!

weizhouapache commented Aug 25, 2025

Uh oh!

Uh oh!

shwstppr commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

blueorangutan commented Aug 26, 2025

Uh oh!

Uh oh!

shwstppr commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

blueorangutan commented Sep 10, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 15, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Sep 30, 2025

Uh oh!

shwstppr commented Sep 30, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shwstppr commented Oct 8, 2025

Uh oh!

blueorangutan commented Oct 8, 2025

Uh oh!

blueorangutan commented Oct 8, 2025

Uh oh!

weizhouapache commented Oct 8, 2025

Uh oh!

DaanHoogland commented Oct 8, 2025

Uh oh!

shwstppr commented Oct 8, 2025

Uh oh!

weizhouapache commented Nov 7, 2025

shwstppr commented Jul 29, 2025 •

edited

Loading

codecov bot commented Jul 29, 2025 •

edited

Loading