Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Currently wrong parameter - 'itemd' is passed to the deleteTrafficType method.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Currently wrong parameter - 'itemd' is passed to the `deleteTrafficType`
method.

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@shwstppr shwstppr requested a review from rajujith July 30, 2025 06:19
@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.17%. Comparing base (ca6d2dc) to head (9d8c57c).
⚠️ Report is 6 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #11337   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11362    11367    +5     
=========================================
  Files          5415     5415           
  Lines        476030   476050   +20     
  Branches      58115    58118    +3     
=========================================
+ Hits          72246    72264   +18     
+ Misses       395701   395698    -3     
- Partials       8083     8088    +5     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11337 (QA-JID-704)

@sureshanaparti sureshanaparti merged commit 3850445 into apache:4.19 Jul 31, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the fix-ui-deletetraffictype branch July 31, 2025 10:04
@DaanHoogland DaanHoogland added this to the 4.19.4 milestone Jul 31, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
Currently wrong parameter - 'itemd' is passed to the `deleteTrafficType` method.

Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants