-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix delete traffic type #11337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix delete traffic type #11337
Conversation
Currently wrong parameter - 'itemd' is passed to the `deleteTrafficType` method. Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11337 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11362 11367 +5
=========================================
Files 5415 5415
Lines 476030 476050 +20
Branches 58115 58118 +3
=========================================
+ Hits 72246 72264 +18
+ Misses 395701 395698 -3
- Partials 8083 8088 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
UI build: ✔️ |
Currently wrong parameter - 'itemd' is passed to the `deleteTrafficType` method. Signed-off-by: Abhishek Kumar <[email protected]>
Description
Currently wrong parameter - 'itemd' is passed to the
deleteTrafficTypemethod.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?