Skip to content

Conversation

@harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Aug 4, 2025

Description

This PR fixes a table creation which failed for me during an environment upgrade

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.37%. Comparing base (58484fb) to head (6b7600e).
⚠️ Report is 8 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11388      +/-   ##
============================================
+ Coverage     16.16%   17.37%   +1.20%     
- Complexity    13282    15220    +1938     
============================================
  Files          5656     5885     +229     
  Lines        497974   524875   +26901     
  Branches      60392    64035    +3643     
============================================
+ Hits          80498    91190   +10692     
- Misses       408512   423394   +14882     
- Partials       8964    10291    +1327     
Flag Coverage Δ
uitests 3.63% <ø> (-0.38%) ⬇️
unittests 18.41% <ø> (+1.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@harikrishna-patnala harikrishna-patnala changed the base branch from main to 4.20 August 4, 2025 09:30
@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan package

@apache apache deleted a comment from blueorangutan Aug 4, 2025
@sureshanaparti sureshanaparti requested a review from Copilot August 4, 2025 09:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a database schema upgrade issue by adding IF NOT EXISTS clause to the nsx_providers table creation statement, preventing failures during environment upgrades when the table already exists.

  • Adds IF NOT EXISTS clause to CREATE TABLE statement for nsx_providers

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14537

@sureshanaparti sureshanaparti merged commit 53bc435 into apache:4.20 Aug 4, 2025
25 checks passed
@sureshanaparti sureshanaparti deleted the fixCreateStatementForSaferUpgrades branch August 4, 2025 12:41
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants