-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix create statement for safer upgrades #11388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create statement for safer upgrades #11388
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11388 +/- ##
============================================
+ Coverage 16.16% 17.37% +1.20%
- Complexity 13282 15220 +1938
============================================
Files 5656 5885 +229
Lines 497974 524875 +26901
Branches 60392 64035 +3643
============================================
+ Hits 80498 91190 +10692
- Misses 408512 423394 +14882
- Partials 8964 10291 +1327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a database schema upgrade issue by adding IF NOT EXISTS clause to the nsx_providers table creation statement, preventing failures during environment upgrades when the table already exists.
- Adds
IF NOT EXISTSclause toCREATE TABLEstatement fornsx_providers
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14537 |
Description
This PR fixes a table creation which failed for me during an environment upgrade
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?