cleanup: remove com.cloud.user.MockAccountManagerImpl #11392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces com.cloud.user.MockAccountManagerImpl with Mockito.mock(AccountManager.class) Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11392 +/- ##
============================================
- Coverage 17.35% 17.35% -0.01%
+ Complexity 15231 15227 -4
============================================
Files 5885 5885
Lines 525611 525611
Branches 64160 64160
============================================
- Hits 91224 91214 -10
- Misses 424090 424101 +11
+ Partials 10297 10296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Contributor
|
I do not think we need any test but packaging on this one. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14555 |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 4, 2025
Replaces com.cloud.user.MockAccountManagerImpl with Mockito.mock(AccountManager.class) Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces com.cloud.user.MockAccountManagerImpl with Mockito.mock(AccountManager.class)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?