linstor: fix getVolumeStats if multiple Linstor primary storages are used

[rp-]

Description

We didn't account for caching the volume stats for each used Linstor cluster, so the first asked Linstor cluster would prevent caching for all the others and so null was returned.

Now we have invalidate counters for each Linstor cluster and also store the cache result with the Linstor cluster address prefixed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

ACS cluster with 2 different Linstor clusters

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.18%. Comparing base (de5188e) to head (e5020d9).
⚠️ Report is 4 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	6.25%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11397   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
- Complexity    11363    11369    +6     
=========================================
  Files          5415     5415           
  Lines        476061   476066    +5     
  Branches      58122    58123    +1     
=========================================
+ Hits          72269    72276    +7     
+ Misses       395702   395701    -1     
+ Partials       8090     8089    -1     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.90% <6.25%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14636

[sureshanaparti]

linsor plugin changes only, @rp- confirmed tests with linsor.

[rp-]

@weizhouapache I just noticed that this commit seems to be missing on the 4.20 branch?

[weizhouapache]

@rp-
it is not in 4.20.1.0 release, but in 4.20 branch

you can check
https://github.com/apache/cloudstack/blob/4.20/plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java

[rp-]

@rp- it is not in 4.20.1.0 release, but in 4.20 branch

you can check https://github.com/apache/cloudstack/blob/4.20/plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java

Ah ok, sorry, I was looking for the commit message...., but it was hidden behind the "Merge ...." message