-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: fix addHost error in zone creation wizard #11401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11401 +/- ##
============================================
- Coverage 15.18% 15.17% -0.01%
- Complexity 11363 11365 +2
============================================
Files 5415 5415
Lines 476061 476061
Branches 58122 58122
============================================
- Hits 72269 72256 -13
- Misses 395702 395719 +17
+ Partials 8090 8086 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@blueorangutan package |
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @rosi-shapeblue for the testing ! quick question, when you fix the incorrect storage path, were you able to add the host and complete the zone creation ? |
@weizhouapache - yes, it works (you can check Case 1 in my comment #11401 (review) ). Once completing the Wizard, the Zone was created successfully. |
Description
This PR fixes #10713
PR #9231 put the code change in a wrong method (
updateConfiguration
, should beaddHost
)Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?