Skip to content

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Aug 6, 2025

Description

This PR fixes #10713

PR #9231 put the code change in a wrong method (updateConfiguration, should be addHost)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Aug 6, 2025 that may be closed by this pull request
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.17%. Comparing base (de5188e) to head (fd92379).
⚠️ Report is 3 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #11401      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
- Complexity    11363    11365       +2     
============================================
  Files          5415     5415              
  Lines        476061   476061              
  Branches      58122    58122              
============================================
- Hits          72269    72256      -13     
- Misses       395702   395719      +17     
+ Partials       8090     8086       -4     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache added this to the 4.19.4 milestone Aug 6, 2025
@weizhouapache
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11401 (QA-JID-720)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache marked this pull request as ready for review August 8, 2025 06:55
@rosi-shapeblue rosi-shapeblue self-assigned this Aug 12, 2025
@rosi-shapeblue
Copy link
Collaborator

@blueorangutan package

@blueorangutan
Copy link

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14609

rosi-shapeblue

This comment was marked as duplicate.

Copy link
Collaborator

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and verified the fix

Test Evidence

1. Correct Storage Path 1

Screenshot from 2025-08-15 11-53-20 Screenshot from 2025-08-15 11-53-26

2. Incorrect Storage Path 2

Screenshot from 2025-08-15 11-52-58 Screenshot from 2025-08-15 11-53-12

3. Incorrect Storage Setup
Screenshot from 2025-08-15 11-52-39
Screenshot from 2025-08-15 11-52-35

@weizhouapache
Copy link
Member Author

thanks @rosi-shapeblue for the testing !

quick question, when you fix the incorrect storage path, were you able to add the host and complete the zone creation ?

@rosi-shapeblue
Copy link
Collaborator

thanks @rosi-shapeblue for the testing !

quick question, when you fix the incorrect storage path, were you able to add the host and complete the zone creation ?

@weizhouapache - yes, it works (you can check Case 1 in my comment #11401 (review) ). Once completing the Wizard, the Zone was created successfully.

@sureshanaparti sureshanaparti merged commit d4bd587 into apache:4.19 Aug 15, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-pr9231 branch August 15, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation / zone setup
6 participants