Skip to content

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Aug 7, 2025

Description

This PR adds LB service to Network and VPC offerings (in NAT mode) created for Netris Provider

Fixes: #11411

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (70a4503) to head (72c32e9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...he/cloudstack/api/command/utils/OfferingUtils.java 0.00% 13 Missing ⚠️
...ommand/admin/network/CreateNetworkOfferingCmd.java 0.00% 2 Missing ⚠️
...ck/api/command/admin/vpc/CreateVPCOfferingCmd.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11410      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
  Complexity    15285    15285              
============================================
  Files          5888     5889       +1     
  Lines        526130   526143      +13     
  Branches      64232    64233       +1     
============================================
  Hits          91542    91542              
- Misses       424255   424268      +13     
  Partials      10333    10333              
Flag Coverage Δ
uitests 3.62% <ø> (ø)
unittests 18.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 changed the title Add LB service to Custom VPC/Network offerings Add LB service to Custom Netris VPC/Network offerings Aug 7, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2025

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@harikrishna-patnala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14971

@harikrishna-patnala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14974

@nvazquez
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14311)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55580 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11410-t14311-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.15 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 31.93 test_kubernetes_clusters.py

@harikrishna-patnala harikrishna-patnala merged commit 23a53e2 into main Sep 16, 2025
48 of 50 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Sep 16, 2025
@harikrishna-patnala harikrishna-patnala deleted the netris-net-offerings-lb branch September 16, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Creation of Netris NAT VPC Offerings and Network Offerings missing the Lb service

5 participants