Add LB service to Custom Netris VPC/Network offerings #11410
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11410 +/- ##
============================================
- Coverage 17.35% 17.35% -0.01%
+ Complexity 15232 15229 -3
============================================
Files 5885 5885
Lines 525618 525622 +4
Branches 64157 64161 +4
============================================
- Hits 91225 91213 -12
- Misses 424094 424113 +19
+ Partials 10299 10296 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pearl1594
changed the title
|
| @@ -297,7 +297,8 @@ public List<String> getSupportedServices() { | |||
| SourceNat.getName(), | |||
| PortForwarding.getName())); | |||
| } | |||
| if (getNsxSupportsLbService()) { | |||
| if (getNsxSupportsLbService() || (provider != null && provider.equalsIgnoreCase("Netris") && | |||
There was a problem hiding this comment.
@Pearl1594 Please see if the methods below will help improve readability. Otherwise LGTM
private boolean isNsxWithLb() {
return "Nsx".equalsIgnoreCase(provider) && getNsxSupportsLbService();
}
private boolean isNsxWithoutLb() {
return "Nsx".equalsIgnoreCase(provider) && !getNsxSupportsLbService();
}
private boolean isNetrisNatted() {
return "Netris".equalsIgnoreCase(provider) &&
NetworkOffering.NetworkMode.NATTED.name().equalsIgnoreCase(getNetworkMode());
}
private boolean isNetrisRouted() {
return "Netris".equalsIgnoreCase(provider) &&
NetworkOffering.NetworkMode.ROUTED.name().equalsIgnoreCase(getNetworkMode());
}
Description
This PR adds LB service to Network and VPC offerings (in NAT mode) created for Netris Provider
Fixes: #11411
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?