Skip to content

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes these issues:
image

image image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (7d59bfe) to head (a038862).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11413      +/-   ##
============================================
- Coverage     17.35%   17.35%   -0.01%     
+ Complexity    15232    15230       -2     
============================================
  Files          5885     5885              
  Lines        525618   525632      +14     
  Branches      64157    64161       +4     
============================================
- Hits          91225    91216       -9     
- Misses       424094   424120      +26     
+ Partials      10299    10296       -3     
Flag Coverage Δ
uitests 3.63% <ø> (-0.01%) ⬇️
unittests 18.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Aug 7, 2025

@Pearl1594
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11413 (QA-JID-725)

@DaanHoogland
Copy link
Contributor

@Pearl1594 is this only applicable on main?

@DaanHoogland
Copy link
Contributor

testing this in qa:
Screenshot 2025-08-08 at 11 15 10
seems like this is the same issue somewhat, though I am not sure F5 is still actively supported.

@sureshanaparti
Copy link
Contributor

testing this in qa: Screenshot 2025-08-08 at 11 15 10 seems like this is the same issue somewhat, though I am not sure F5 is still actively supported.

@Pearl1594 can you check/fix this?

@sureshanaparti
Copy link
Contributor

@Pearl1594 With the changes, when I clicked on Nsx, Netris, Tungsten, nothing happens (old view remains as is), at least show message indicating the plugin is disabled, or hide all the disabled providers.

@Pearl1594
Copy link
Contributor Author

The provider should appear disabled i.e., in red - which should be an indicator that it is disabled. As historically, we haven't explicitly prompted the user that a provider is disabled with any notification per se, which is why I continued with that behaviour.

@@ -185,6 +199,18 @@ export default {
}

try {
const providers = ['tungsten', 'nsx', 'netris']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this list be retrieved?

Copy link
Contributor Author

@Pearl1594 Pearl1594 Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean from the backend? I don't believe so that we have a way (API) to identify external network providers.
I mean, we can get the list of all network service providers, but not what needs a global setting to be enabled to actually use it.

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Aug 18, 2025

testing this in qa: Screenshot 2025-08-08 at 11 15 10 seems like this is the same issue somewhat, though I am not sure F5 is still actively supported.

seems like f5 was removed from the backend: #7023 - but the UI wasn't handled then.
this : #11463 should address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants