Skip to content

Conversation

@nvazquez
Copy link
Contributor

Description

This PR fixes an UI issue on Basic zones - duplicate Edit button:

Screenshot 2025-08-11 at 7 25 11 AM

After the fix:

Screenshot 2025-08-11 at 7 25 32 AM

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (7d59bfe) to head (e280dfe).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11427   +/-   ##
=========================================
  Coverage     17.35%   17.36%           
- Complexity    15232    15234    +2     
=========================================
  Files          5885     5885           
  Lines        525618   525619    +1     
  Branches      64157    64157           
=========================================
+ Hits          91225    91253   +28     
+ Misses       424094   424071   -23     
+ Partials      10299    10295    -4     
Flag Coverage Δ
uitests 3.63% <ø> (-0.01%) ⬇️
unittests 18.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nvazquez for fixing this. code LGTM and verified locally.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11427 (QA-JID-728)

Copy link
Collaborator

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested and verified the fix

  • No duplicated Edit button on Basic zones
image
  • No duplicated Edit button on other types of Zones
Screenshot from 2025-08-11 14-09-17 Screenshot from 2025-08-11 14-09-10 Screenshot from 2025-08-11 14-09-04

@sureshanaparti sureshanaparti merged commit 53b0264 into apache:main Aug 11, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 11, 2025
@sureshanaparti sureshanaparti deleted the 421-fix-double-edit-zone-basic branch August 11, 2025 11:10
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants