Skip to content

UI: Add validator for CIDR being passed #11465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Oct 13, 2025
Merged

UI: Add validator for CIDR being passed #11465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
068acba
UI: Add validator for CIDR being passed
Pearl1594 Aug 18, 2025
27408f7
retain mandatory field indicator, remove log
Pearl1594 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ui/src/utils/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,25 @@ export function toCsv ({ keys = null, data = null, columnDelimiter = ',', lineDe

return result
}

export function isValidIPv4Cidr (rule, value) {
console.log('here')
return new Promise((resolve, reject) => {
if (!value) {
reject(new Error('Required input'))
return
}
const cidrRegex = /^(\d{1,3}\.){3}\d{1,3}\/([0-9]|[1-2][0-9]|3[0-2])$/
if (!cidrRegex.test(value)) {
reject(new Error('Invalid CIDR format'))
return
}
const ip = value.split('/')[0]
const octets = ip.split('.').map(Number)
if (octets.some(octet => octet < 0 || octet > 255)) {
reject(new Error('Invalid CIDR format'))
return
}
resolve()
})
}
4 changes: 3 additions & 1 deletion ui/src/views/network/CreateVpc.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@
import { ref, reactive, toRaw } from 'vue'
import { getAPI, postAPI } from '@/api'
import { isAdmin, isAdminOrDomainAdmin } from '@/role'
import { isValidIPv4Cidr } from '@/utils/util.js'
import ResourceIcon from '@/components/view/ResourceIcon'
import TooltipLabel from '@/components/widgets/TooltipLabel'
import OwnershipSelection from '@/views/compute/wizard/OwnershipSelection.vue'
Expand Down Expand Up @@ -291,6 +292,7 @@ export default {
this.rules = reactive({
name: [{ required: true, message: this.$t('message.error.required.input') }],
zoneid: [{ required: true, message: this.$t('label.required') }],
cidr: [{ validator: isValidIPv4Cidr }],
vpcofferingid: [{ required: true, message: this.$t('label.required') }]
})
},
Expand Down Expand Up @@ -417,7 +419,7 @@ export default {
},
updateCidrRule () {
if (!this.selectedVpcOfferingHavingRoutedNetworkMode) {
this.rules.cidr = [{ required: true, message: this.$t('message.error.required.input') }]
this.rules.cidr = [{ validator: isValidIPv4Cidr }]
} else {
delete this.rules.cidr
}
Expand Down
Loading