Fix of create a template from a StorPool snapshot on another zone #11490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a snapshot has a copy on StorPool primary storage in another zone, but the original snapshot resides on secondary storage, creating a template from the copied snapshot results in the template being created in the first zone. If the snapshot.backup.to.secondary setting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage.
Contributor
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11490 +/- ##
=========================================
Coverage 17.35% 17.36%
- Complexity 15230 15234 +4
=========================================
Files 5886 5886
Lines 525685 525680 -5
Branches 64159 64159
=========================================
+ Hits 91247 91261 +14
+ Misses 424138 424120 -18
+ Partials 10300 10299 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14681 |
Contributor
|
Hi @rp- Can you test this PR with linstor and share your results. Thanks. |
Contributor
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-14089)
|
rp-
reviewed
Aug 21, 2025
Contributor
rp-
left a comment
rp-
left a comment
There was a problem hiding this comment.
create template from snapshot worked, BUT
create volume from snapshot did NOT.
with Linstor
Contributor
|
Contributor
Author
|
thanks @rp-, I'm working on it |
Contributor
Author
|
@rp-, can you please test this again if you have time? |
Contributor
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14690 |
Contributor
works now! |
rp-
approved these changes
Aug 21, 2025
Contributor
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
...chestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
Outdated
Show resolved
Hide resolved
...chestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
Outdated
Show resolved
Hide resolved
Contributor
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
nvazquez
approved these changes
Aug 21, 2025
Contributor
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - have tried on env with 2 zones having cluster wide NFS storages:
Deploy VM on Zone A:
Setting snapshot.backup.to.secondary = false:
- Take snapshot of VM’s ROOT volume on Zone A
- Create template from snapshot on Zone A
- Deploy VM from template on Zone A
Setting snapshot.backup.to.secondary = true:
- Take snapshot of VM’s ROOT volume on Zone A and Zone B (by adding the additional zone on the Take snapshot wizard)
- Create template from snapshot on Zone A
- Create template from snapshot on Zone B
- Deploy VM from template on Zone A
- Deploy VM from template on Zone B
Contributor
Author
|
Tested with Ceph
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14701 |
Contributor
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Contributor
|
LGTM. Verified volume snapshot creation with volumes on NFS primary (backed to NFS image store) & PowerFlex pools, and able to create template & volume from snapshots on NFS image store, create template from snapshot on PowerFlex storage pool. |
sureshanaparti
approved these changes
Aug 21, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.21.0
|
[SF] Trillian test result (tid-14096)
|
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 4, 2025
…ache#11490) * Fix of create template from snapshot on another zone When a snapshot has a copy on StorPool primary storage in another zone, but the original snapshot resides on secondary storage, creating a template from the copied snapshot results in the template being created in the first zone. If the snapshot.backup.to.secondary setting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage. * update snapshot info depending on the data store role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
regression from #11452
snapshot.backup.to.secondarysetting is disabled, and a user creates a volume or template from a snapshot, the snapshot is temporarily backed up to secondary storage during the operation. After the operation, this backup should be deleted. However, the snapshot currently remains on both primary and secondary storage.Types of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
manually tested and still testing it