scripts: fix external provision to use correct power state & hyperv powersync #11504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The valid states are poweron and poweroff. Signed-off-by: Rohit Yadav <[email protected]>
rohityadavcloud
requested review from
abh1sar,
harikrishna-patnala and
shwstppr
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11504 +/- ##
============================================
- Coverage 17.36% 17.36% -0.01%
- Complexity 15232 15233 +1
============================================
Files 5886 5886
Lines 525680 525680
Branches 64159 64159
============================================
- Hits 91261 91260 -1
Misses 424120 424120
- Partials 10299 10300 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shwstppr
approved these changes
Aug 25, 2025
Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Member
Author
|
I could also manage to fix the hyperv powerstate not syncing. cc @abh1sar @shwstppr @harikrishna-patnala Manually tested in a HyperV WS 2019, Proxmox VE9 and sample/test extension. |
rohityadavcloud
commented
Aug 25, 2025
rohityadavcloud
commented
Aug 25, 2025
rohityadavcloud
changed the title
abh1sar
approved these changes
Aug 25, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.22.0
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 4, 2025
…owersync (apache#11504) * scripts: fix external provision to use correct power state The valid states are poweron and poweroff. Signed-off-by: Rohit Yadav <[email protected]> * strip string while processing powerstate for HyperV Signed-off-by: Rohit Yadav <[email protected]> * ignore warning that spills over to exten output string Signed-off-by: Rohit Yadav <[email protected]> --------- Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid states are poweron and poweroff.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?