VPC VR: return UNKNOWN redundant state if no guest nics

[weizhouapache]

Description

This PR fixes #10677

steps to reproduce the issue

• create a redundant VPC
• create a vpc tier
• create a vm but do not start it
• check the VR redundant state after a while, both vpc VRs are FAULT state

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (25f93b1) to head (866f2b8).
⚠️ Report is 2 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11518   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
  Complexity    11369    11369           
=========================================
  Files          5415     5415           
  Lines        476066   476066           
  Branches      58123    58123           
=========================================
+ Hits          72281    72284    +3     
+ Misses       395698   395697    -1     
+ Partials       8087     8085    -2     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.90% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm, one remark though

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14739

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14119)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56297 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11518-t14119-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	47.25	test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics	Failure	1449.21	test_vpc_redundant.py

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14123)

[harikrishna-patnala]

Tested LGTM. VRs state is Unknown for both after a while too.

[weizhouapache]

thanks @harikrishna-patnala for the testing

I am wondering if the status should be UNKNOWN or BACKUP
what do you think ? @harikrishna-patnala @DaanHoogland

[harikrishna-patnala]

thanks @harikrishna-patnala for the testing

I am wondering if the status should be UNKNOWN or BACKUP what do you think ? @harikrishna-patnala @DaanHoogland

UNKNOWN seems to be fine @weizhouapache as it is really an unknown state right, both as BACKUP may not look good.

[weizhouapache]

UNKNOWN seems to be fine @weizhouapache as it is really an unknown state right, both as BACKUP may not look good.

correct, BACKUP state means there is another VR in PRIMARY state
let's keep UNKNOWN, thanks @harikrishna-patnala

@DaanHoogland
if no objection, let's merge ?