-
Notifications
You must be signed in to change notification settings - Fork 1.3k
kvm: fix vm deployment with direct-download iso #11532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Fixes apache#11521 QCOW2 file check is not needed when the image format is ISO Signed-off-by: Abhishek Kumar <[email protected]>
698a705 to
47c8042
Compare
|
@weizhouapache thanks for the review. I'm restarting packaging as I changed the order of conditions @blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11532 +/- ##
=============================================
- Coverage 16.16% 4.00% -12.16%
=============================================
Files 5656 402 -5254
Lines 497884 32625 -465259
Branches 60378 5796 -54582
=============================================
- Hits 80463 1308 -79155
+ Misses 408466 31167 -377299
+ Partials 8955 150 -8805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14764 |
|
lgtm, tested |
|
good, thanks @sudo87 @blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14772 |
Description
Fixes #11521
QCOW2 file check is not needed when the image format is ISO
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?