server,engine-schema: make config - use.https.to.upload zone scoped #11539

shwstppr · 2025-08-30T10:49:52Z

Description

Configuration use.https.to.upload should be zone scoped as it affects the upload URL for SSVMs and probably has nothing to do with the storage pools.
Also, on changing configuration SSVM seems to be needing recreation as the flag is passed only during deployment.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Configuration `use.https.to.upload` should be zone scoped as it affects the upload URL for SSVMs and probably has nothing to do with the storage pools. Also, on changing configuration SSVM seems to be needing recreation as the flag is passed only during deployment. Signed-off-by: Abhishek Kumar <[email protected]>

codecov · 2025-08-30T10:59:06Z

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.54%. Comparing base (0e8b0b8) to head (1190367).

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	6 Missing ⚠️
...age/command/TemplateOrVolumePostUploadCommand.java	0.00%	5 Missing ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java	0.00%	4 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	1 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11539      +/-   ##
============================================
- Coverage     17.55%   17.54%   -0.01%     
+ Complexity    15525    15524       -1     
============================================
  Files          5908     5908              
  Lines        528799   528804       +5     
  Branches      64580    64580              
============================================
- Hits          92806    92802       -4     
- Misses       425555   425563       +8     
- Partials      10438    10439       +1

Flag	Coverage Δ
uitests	`3.58% <ø> (ø)`
unittests	`18.61% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-09-01T10:00:11Z

@blueorangutan package

blueorangutan · 2025-09-01T10:02:06Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-01T11:46:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14805

github-actions · 2025-09-03T10:50:16Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2025-09-25T08:24:18Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-10-01T12:39:01Z

@blueorangutan package

blueorangutan · 2025-10-01T12:40:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-01T14:27:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15254

DaanHoogland

clgtm

github-actions · 2025-10-08T07:51:47Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-10-09T10:27:18Z

@blueorangutan package

blueorangutan · 2025-10-09T10:28:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-09T12:55:49Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15360

DaanHoogland · 2025-10-09T13:13:39Z

@blueorangutan package

blueorangutan · 2025-10-09T13:14:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-09T15:41:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15368

github-actions · 2025-10-10T09:39:45Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-10-10T15:19:33Z

@blueorangutan package

blueorangutan · 2025-10-10T15:20:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-10T17:30:22Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15408

shwstppr · 2025-10-11T02:16:44Z

@blueorangutan package

blueorangutan · 2025-10-11T02:18:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-11T03:49:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15413

DaanHoogland · 2025-10-13T07:54:18Z

@blueorangutan test

blueorangutan · 2025-10-13T07:56:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-14T01:18:15Z

[SF] Trillian test result (tid-14642)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 58814 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11539-t14642-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2025-10-15T11:37:28Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-10-16T05:16:50Z

@blueorangutan package

blueorangutan · 2025-10-16T05:18:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-16T07:01:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15475

boring-cyborg bot added component:api component:secondary-storage component:ssvm component:storage labels Aug 30, 2025

shwstppr force-pushed the fix-usehttpsupload-config branch from ef8bfd3 to 9de2cc8 Compare August 30, 2025 10:51

Merge branch 'main' into fix-usehttpsupload-config

d51aceb

github-actions bot added the status:has-conflicts label Sep 3, 2025

Merge branch 'main' into fix-usehttpsupload-config

feb2b5a

github-actions bot removed the status:has-conflicts label Sep 4, 2025

github-actions bot added the status:has-conflicts label Sep 25, 2025

Merge branch 'main' into fix-usehttpsupload-config

7810b48

shwstppr marked this pull request as ready for review October 1, 2025 12:38

github-actions bot removed the status:has-conflicts label Oct 1, 2025

DaanHoogland approved these changes Oct 3, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Oct 8, 2025

Merge branch 'main' into fix-usehttpsupload-config

fc8b919

github-actions bot removed the status:has-conflicts label Oct 9, 2025

github-actions bot added the status:has-conflicts label Oct 10, 2025

Merge branch 'main' into fix-usehttpsupload-config

9d89226

github-actions bot removed the status:has-conflicts label Oct 10, 2025

DaanHoogland added the status:needs-testing label Oct 13, 2025

vishesh92 assigned vishesh92 and unassigned vishesh92 Oct 13, 2025

github-actions bot added the status:has-conflicts label Oct 15, 2025

Merge branch 'main' into fix-usehttpsupload-config

1190367

github-actions bot removed the status:has-conflicts label Oct 16, 2025

server,engine-schema: make config - use.https.to.upload zone scoped #11539

Are you sure you want to change the base?

server,engine-schema: make config - use.https.to.upload zone scoped #11539

Uh oh!

Conversation

shwstppr commented Aug 30, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Sep 1, 2025

Uh oh!

blueorangutan commented Sep 1, 2025

Uh oh!

blueorangutan commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 25, 2025

Uh oh!

shwstppr commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

blueorangutan commented Oct 1, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

shwstppr commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

DaanHoogland commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

DaanHoogland commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

shwstppr commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

DaanHoogland commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

shwstppr commented Oct 16, 2025

Uh oh!

blueorangutan commented Oct 16, 2025

Uh oh!

blueorangutan commented Oct 16, 2025

Uh oh!

codecov bot commented Aug 30, 2025 •

edited

Loading