ui: donot remove account, domain from query on public ip filter change #11575
Conversation
Currently, when changing filter on public IP view (Free, Reserved, Allocated) it removes the account and domain values from query. This PR prevents that as public IP view filters have no relation with account/domain. Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11575 +/- ##
=========================================
Coverage 16.17% 16.17%
- Complexity 13287 13294 +7
=========================================
Files 5656 5656
Lines 498008 498083 +75
Branches 60404 60416 +12
=========================================
+ Hits 80541 80568 +27
- Misses 408505 408551 +46
- Partials 8962 8964 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
vishesh92
left a comment
vishesh92
left a comment
There was a problem hiding this comment.
lgtm. tested on simulator ui. works as expected.
apache#11575) Signed-off-by: Abhishek Kumar <[email protected]>
4 participants
Description
Currently, when changing the filter on public IP view (Free, Reserved, Allocated), it removes the account and domain values from the query params. This PR prevents the removal of the account/domain query params as public IP view filters have no relation with them.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?