ui: searchview change should only remove related query params #11576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
With changefilter-honored-on-searchview-change.mp4 |
Prevents removing all query params when there is a change from SearchView element. Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
force-pushed
the
ui-fix-searchview-removesqueryparams
branch
from
12ea655 to
f854965
Compare
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11576 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
Complexity 13287 13287
============================================
Files 5656 5656
Lines 498008 498015 +7
Branches 60404 60407 +3
============================================
Hits 80541 80541
- Misses 408505 408511 +6
- Partials 8962 8963 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
harikrishna-patnala
approved these changes
Sep 10, 2025
Contributor
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
tested on https://qa.cloudstack.cloud/client/pr/11576/#
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents removing all query params when there is a change from SearchView element.
Currently, all query params are removed as soon as the search is applied from SearchView element. This PR changes to the behaviour to removing only the query params which are from searchFilters of the section.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before fix,
filter-not-honored-on-searchview-change.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?