-
Notifications
You must be signed in to change notification settings - Fork 1.2k
pre-commit add chmod 644 manual hook for Markdown
#11651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit add chmod 644 manual hook for Markdown
#11651
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11651 +/- ##
=========================================
Coverage 17.56% 17.56%
Complexity 15533 15533
=========================================
Files 5909 5909
Lines 529013 529013
Branches 64605 64605
=========================================
+ Hits 92912 92914 +2
Misses 425652 425652
+ Partials 10449 10447 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15536 |
Description
This PR adds a manual hook that can be used in a full repo clean up on a local machine.
See some of my discussion about manual hooks here:
refs apache/cloudstack-www#362
So Windows users don't normally have the
chmodcommand so this hook can be run by macOS and Linux users when needed. And I have also added this to the CI with a--hook-stage manualrun so we don't lose coverage.In future we can add more manual stage hooks.
Some other ASF projects that use the hooks from Lucas-C are Apache Sedona and Apache Airflow:
https://github.com/apache/sedona/blob/6029bec540e11b52d0a21819e23db6f4001cec94/.pre-commit-config.yaml#L78
https://github.com/apache/airflow/blob/ec758b7abf189d5027e830d91effa85e17659249/.pre-commit-config.yaml#L50
Also I added Lucas-C hooks to mruby:
https://github.com/mruby/mruby/blob/437b47dca7ce8a2bf8a660dbbd920caa33c14794/.pre-commit-config.yaml#L69
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran pre-commit and all the hooks locally
How did you try to break this feature and the system with this change?