Skip to content

KVM: skip mountpoint check for RBD storage pools #11690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

KVM: skip mountpoint check for RBD storage pools #11690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions ...hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,27 @@ public void storagePoolRefresh(StoragePool pool) {
}

private void checkNetfsStoragePoolMounted(String uuid) {
Copy link
Member

@weizhouapache weizhouapache Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is called only once by

cloudstack/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

Lines 879 to 881 in 4884f52

if (type == StoragePoolType.NetworkFilesystem) {
checkNetfsStoragePoolMounted(name);
}

this PR seems not needed

Copy link
Member

@weizhouapache weizhouapache Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanvetorello
have you faced any issue in your testing ? any logs ?

Copy link
Contributor Author

@jeanvetorello jeanvetorello Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the help ,
I’m going to open an issue describing the problem in detail, along with the logs, to see if you can help resolve it.

Copy link
Contributor Author

@jeanvetorello jeanvetorello Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11724

Copy link
Member

@weizhouapache weizhouapache Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jeanvetorello

did you face the issue #11697 when you test with this patch or not ?

String targetPath = _mountPoint + File.separator + uuid;
int mountpointResult = Script.runSimpleBashScriptForExitValue("mountpoint -q " + targetPath);
if (mountpointResult != 0) {
String errMsg = String.format("libvirt failed to mount storage pool %s at %s", uuid, targetPath);
logger.error(errMsg);
throw new CloudRuntimeException(errMsg);
try {
// lookup the storage pool definition
Connect conn = LibvirtConnection.getConnection();
StoragePool pool = conn.storagePoolLookupByUUIDString(uuid);
LibvirtStoragePoolDef def = getStoragePoolDef(conn, pool);

// Skip mountpoint check if pool type is RBD
if (def.getPoolType() == LibvirtStoragePoolDef.PoolType.RBD) {
logger.debug("Skipping mountpoint check for RBD pool " + uuid);
return;
}

String targetPath = _mountPoint + File.separator + uuid;
int mountpointResult = Script.runSimpleBashScriptForExitValue("mountpoint -q " + targetPath);
if (mountpointResult != 0) {
String errMsg = String.format("libvirt failed to mount storage pool %s at %s", uuid, targetPath);
logger.error(errMsg);
throw new CloudRuntimeException(errMsg);
}
} catch (LibvirtException e) {
throw new CloudRuntimeException("Failed to check storage pool type for " + uuid, e);
}
}

Expand Down
Loading