Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Fixes #11700

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.39%. Comparing base (8089d32) to head (6e7b9f2).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11702      +/-   ##
============================================
+ Coverage     17.36%   17.39%   +0.03%     
- Complexity    15245    15284      +39     
============================================
  Files          5888     5891       +3     
  Lines        525831   526296     +465     
  Branches      64183    64260      +77     
============================================
+ Hits          91298    91544     +246     
- Misses       424227   424407     +180     
- Partials      10306    10345      +39     
Flag Coverage Δ
uitests 3.61% <ø> (-0.02%) ⬇️
unittests 18.44% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <[email protected]>
@apache apache deleted a comment from blueorangutan Sep 24, 2025
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11702 (QA-JID-757)

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm
tested in qa, one side note: before this patch the registering succeeds after the dialog was loaded. After it doesn’t show an error anymore.

@DaanHoogland
Copy link
Contributor

@shwstppr , you want to work on this further?

@shwstppr shwstppr marked this pull request as ready for review September 24, 2025 14:44
@shwstppr
Copy link
Contributor Author

No @DaanHoogland

@DaanHoogland DaanHoogland merged commit b0c7719 into apache:main Sep 24, 2025
28 checks passed
@DaanHoogland DaanHoogland deleted the ui-fix-regtmpl-adminacc branch September 24, 2025 15:42
@shwstppr shwstppr added this to the 4.22.0 milestone Sep 25, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message for unavailable API when trying to register template as regular user

4 participants