-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: do not show admin only options to users while registering template #11702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes apache#11700 Signed-off-by: Abhishek Kumar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11702 +/- ##
============================================
+ Coverage 17.36% 17.39% +0.03%
- Complexity 15245 15284 +39
============================================
Files 5888 5891 +3
Lines 525831 526296 +465
Branches 64183 64260 +77
============================================
+ Hits 91298 91544 +246
- Misses 424227 424407 +180
- Partials 10306 10345 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
tested in qa, one side note: before this patch the registering succeeds after the dialog was loaded. After it doesn’t show an error anymore.
|
@shwstppr , you want to work on this further? |
Description
Fixes #11700
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?