ui: reset configuration allowed only when value not default

[shwstppr]

Description

Fixes #11643
Disable reset configuration action when the current value for the config is its default value

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

reset-cfg-disabled.mp4

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (5798fb4) to head (ee1bcc6).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11728      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
+ Complexity    15548    15545       -3     
============================================
  Files          5913     5913              
  Lines        529440   529454      +14     
  Branches      64670    64674       +4     
============================================
- Hits          93018    93005      -13     
- Misses       425964   425991      +27     
  Partials      10458    10458              

Flag	Coverage Δ
uitests	3.58% <ø> (-0.01%)	⬇️
unittests	18.63% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11728 (QA-JID-766)

[DaanHoogland]

clgtm

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11728 (QA-JID-814)

[DaanHoogland]

did some testing in qa and will have to retry in a 4.22 env as resetting at domain level did not seem to work.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15856

[blueorangutan]

[SF] Trillian Build Failed (tid-14884)

[DaanHoogland]

did some testing in qa and will have to retry in a 4.22 env as resetting at domain level did not seem to work.

ok, found the quirk:

1. set a value at global level
2. set a value at domain level
3. reset at domain level => adjusted value from global is used and not the default, reset button is still active.
   I think this is kind of expected, but the reset button does not dissappear in this case, while resetting no longer changes the value.

I am not sure if the UI contains enough data to fix this, but it is acceptable to me. (i.e. test succeeds)