refactoring a few smoke tests #11748
Conversation
boring-cyborg
bot
added
component:integration-test
Python
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #11748 +/- ##
=============================================
- Coverage 17.50% 3.61% -13.90%
=============================================
Files 5894 442 -5452
Lines 526845 37259 -489586
Branches 64334 6838 -57496
=============================================
- Hits 92232 1347 -90885
+ Misses 424236 35748 -388488
+ Partials 10377 164 -10213
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15229 |
| Snapshot.delete(snapshot, self.userapiclient, self.zone.id) | ||
| self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.additional_zone.id]) | ||
| self.cleanup.append(snapshot) | ||
| self._cleanup.append(snapshot) |
There was a problem hiding this comment.
isn’t the snapshot to be removed from the cleanup list here?
| time.sleep(420) | ||
| Snapshot.delete(snapshot, self.userapiclient) | ||
| self._cleanup.append(self.volume) | ||
| self._cleanup.append(snapshot) |
There was a problem hiding this comment.
why is this added at this point?
| self.snapshot_id = snapshot.id | ||
| self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id]) | ||
| time.sleep(420) | ||
| Snapshot.delete(snapshot, self.userapiclient) | ||
| self._cleanup.append(snapshot) |
There was a problem hiding this comment.
| self.snapshot_id = snapshot.id | |
| self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id]) | |
| time.sleep(420) | |
| Snapshot.delete(snapshot, self.userapiclient) | |
| self._cleanup.append(snapshot) | |
| self._cleanup.append(snapshot) | |
| self.snapshot_id = snapshot.id | |
| self.helper.verify_snapshot_copies(self.userapiclient, self.snapshot_id, [self.zone.id, self.additional_zone.id]) |
| time.sleep(420) | ||
| Snapshot.delete(snapshot, self.userapiclient) | ||
|
|
||
| self._cleanup.append(snapshot) |
There was a problem hiding this comment.
this should move to just below the create .
also, is the copy a separate entity and should it be in the cleanup list as well?
| self.template = self.helper.create_snapshot_template(self.userapiclient, self.services, self.snapshot_id, self.additional_zone.id) | ||
| if self.additional_zone.id != self.template.zoneid: | ||
| self.fail("Template from snapshot not created in the additional zone") | ||
| self._cleanup.append(snapshot) |
There was a problem hiding this comment.
this should move up a couple of lines to be just below the matching create
| snapshotid=snapshot.id, | ||
| mode="basic", | ||
| ) | ||
| self._cleanup.append(virtual_machine) |
There was a problem hiding this comment.
| self._cleanup.append(virtual_machine) | |
| self.cleanup.append(virtual_machine) |
maybe?
| volumeid=volume.id, | ||
| mode="basic", | ||
| ) | ||
| self._cleanup.append(virtual_machine) |
There was a problem hiding this comment.
| self._cleanup.append(virtual_machine) | |
| self.cleanup.append(virtual_machine) |
?
(as it is an operation on self and not on cls)
Description
Added few more tests scenarios and refactoring
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
ran the smoke tests